matrix-org issueshttps://gitlab.matrix.org/groups/matrix-org/-/issues2022-11-18T22:42:04Zhttps://gitlab.matrix.org/matrix-org/olm/-/issues/13Typescript types lack return types causing upstream strict mode issues2022-11-18T22:42:04ZMichael TelatynskiTypescript types lack return types causing upstream strict mode issueshttps://gitlab.matrix.org/matrix-org/olm/-/blob/master/javascript/index.d.ts lacks return types on its class methods
```
Errors Files
10 node_modules/@matrix-org/olm/index.d.ts:21
```https://gitlab.matrix.org/matrix-org/olm/-/blob/master/javascript/index.d.ts lacks return types on its class methods
```
Errors Files
10 node_modules/@matrix-org/olm/index.d.ts:21
```https://gitlab.matrix.org/matrix-org/olm/-/issues/12WASM binding doesn't support Node 182022-10-10T11:35:57ZMichael TelatynskiWASM binding doesn't support Node 18Emscripten needs updating and the bindings rebuilding
See https://github.com/emscripten-core/emscripten/issues/16913
Needs emscripten minimum version 3.1.13Emscripten needs updating and the bindings rebuilding
See https://github.com/emscripten-core/emscripten/issues/16913
Needs emscripten minimum version 3.1.13https://gitlab.matrix.org/matrix-org/olm/-/issues/8Makefile build doesn't install olm_export.h2021-11-03T08:34:20ZpoljarMakefile build doesn't install olm_export.hRecently the `olm_export.h` include file has been added to the repo. The `CmakeList.txt` file has been updated to install this file in this commit: https://gitlab.matrix.org/matrix-org/olm/-/commit/4fb723cad302204b4faaf4c3f74a7ebec987a85...Recently the `olm_export.h` include file has been added to the repo. The `CmakeList.txt` file has been updated to install this file in this commit: https://gitlab.matrix.org/matrix-org/olm/-/commit/4fb723cad302204b4faaf4c3f74a7ebec987a85c.
The `Makefile` build has not been updated resulting in a incomplete install of the header files. This means that building libs (python-olm mainly) that depend on libolm will fail on systems whit such an install.
The `olm_export.h` file likely just needs to be listed in the [`PUBLIC_HEADERS`](https://gitlab.matrix.org/matrix-org/olm/-/blob/master/Makefile#L37) variable of the Makefile.
We may want to ponder removing the `Makefile` build considering that it doesn't seem to be widely used and it'll likely bitrot again.
Related issues:
* https://github.com/matrix-org/pantalaimon/issues/108
* https://github.com/poljar/weechat-matrix/issues/296https://gitlab.matrix.org/matrix-org/olm/-/issues/7Lint fails for the iOS lib2021-09-07T10:54:30ZManuLint fails for the iOS libRunning the cocoapods linter currently fails on develop.
This prevents us from making a release.
```
❯ pod spec lint OLMKit.podspec --use-libraries --allow-warnings
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:4: warning: already ...Running the cocoapods linter currently fails on develop.
This prevents us from making a release.
```
❯ pod spec lint OLMKit.podspec --use-libraries --allow-warnings
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:4: warning: already initialized constant Pod::MAJOR
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:4: warning: previous definition of MAJOR was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:5: warning: already initialized constant Pod::MINOR
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:5: warning: previous definition of MINOR was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:6: warning: already initialized constant Pod::PATCH
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:6: warning: previous definition of PATCH was here
/var/folders/qx/s5rm3bcj71qgpbxqbdgn54140000gn/T/d20210906-62461-10osbq8/OLMKit.podspec:4: warning: already initialized constant Pod::MAJOR
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:4: warning: previous definition of MAJOR was here
/var/folders/qx/s5rm3bcj71qgpbxqbdgn54140000gn/T/d20210906-62461-10osbq8/OLMKit.podspec:5: warning: already initialized constant Pod::MINOR
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:5: warning: previous definition of MINOR was here
/var/folders/qx/s5rm3bcj71qgpbxqbdgn54140000gn/T/d20210906-62461-10osbq8/OLMKit.podspec:6: warning: already initialized constant Pod::PATCH
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:6: warning: previous definition of PATCH was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:4: warning: already initialized constant Pod::MAJOR
/var/folders/qx/s5rm3bcj71qgpbxqbdgn54140000gn/T/d20210906-62461-10osbq8/OLMKit.podspec:4: warning: previous definition of MAJOR was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:5: warning: already initialized constant Pod::MINOR
/var/folders/qx/s5rm3bcj71qgpbxqbdgn54140000gn/T/d20210906-62461-10osbq8/OLMKit.podspec:5: warning: previous definition of MINOR was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:6: warning: already initialized constant Pod::PATCH
/var/folders/qx/s5rm3bcj71qgpbxqbdgn54140000gn/T/d20210906-62461-10osbq8/OLMKit.podspec:6: warning: previous definition of PATCH was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:4: warning: already initialized constant Pod::MAJOR
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:4: warning: previous definition of MAJOR was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:5: warning: already initialized constant Pod::MINOR
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:5: warning: previous definition of MINOR was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:6: warning: already initialized constant Pod::PATCH
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:6: warning: previous definition of PATCH was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:4: warning: already initialized constant Pod::MAJOR
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:4: warning: previous definition of MAJOR was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:5: warning: already initialized constant Pod::MINOR
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:5: warning: previous definition of MINOR was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:6: warning: already initialized constant Pod::PATCH
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:6: warning: previous definition of PATCH was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:4: warning: already initialized constant Pod::MAJOR
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:4: warning: previous definition of MAJOR was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:5: warning: already initialized constant Pod::MINOR
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:5: warning: previous definition of MINOR was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:6: warning: already initialized constant Pod::PATCH
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:6: warning: previous definition of PATCH was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:4: warning: already initialized constant Pod::MAJOR
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:4: warning: previous definition of MAJOR was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:5: warning: already initialized constant Pod::MINOR
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:5: warning: previous definition of MINOR was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:6: warning: already initialized constant Pod::PATCH
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:6: warning: previous definition of PATCH was here
-> OLMKit (3.2.4)
- NOTE | [OLMKit/olmc,OLMKit/olmcpp] xcodebuild: note: Using new build system
- NOTE | [OLMKit/olmc,OLMKit/olmcpp] xcodebuild: note: Building targets in parallel
- NOTE | [OLMKit/olmc,OLMKit/olmcpp] xcodebuild: note: Using codesigning identity override: -
- NOTE | [OLMKit/olmc,OLMKit/olmcpp] xcodebuild: note: Build preparation complete
- NOTE | [OLMKit/olmc,OLMKit/olmcpp] xcodebuild: note: Planning build
- NOTE | [OLMKit/olmc,OLMKit/olmcpp] xcodebuild: note: Analyzing workspace
- NOTE | [OLMKit/olmc,OLMKit/olmcpp] xcodebuild: note: Constructing build description
- NOTE | [OLMKit/olmc,OLMKit/olmcpp] xcodebuild: Pods.xcodeproj: warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 6.0, but the range of supported deployment target versions is 9.0 to 14.5.99. (in target 'OLMKit' from project 'Pods')
- WARN | xcodebuild: OLMKit/src/ratchet.cpp:38:11: warning: parameter 'new_root_key[out]' not found in the function declaration [-Wdocumentation]
- NOTE | xcodebuild: OLMKit/src/ratchet.cpp:38:11: note: did you mean 'new_root_key'?
- WARN | xcodebuild: OLMKit/src/ratchet.cpp:39:11: warning: parameter 'new_chain_key[out]' not found in the function declaration [-Wdocumentation]
- NOTE | xcodebuild: OLMKit/src/ratchet.cpp:39:11: note: did you mean 'new_chain_key'?
- WARN | xcodebuild: OLMKit/src/ratchet.cpp:412:9: warning: implicit conversion loses integer precision: 'std::size_t' (aka 'unsigned long') to 'std::uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32]
- WARN | xcodebuild: OLMKit/lib/ed25519/src/fe.c:825:12: warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'int32_t' (aka 'int') [-Wshorten-64-to-32]
- WARN | xcodebuild: OLMKit/lib/ed25519/src/fe.c:826:12: warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'int32_t' (aka 'int') [-Wshorten-64-to-32]
- WARN | xcodebuild: OLMKit/lib/ed25519/src/fe.c:827:12: warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'int32_t' (aka 'int') [-Wshorten-64-to-32]
- WARN | xcodebuild: OLMKit/lib/ed25519/src/fe.c:828:12: warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'int32_t' (aka 'int') [-Wshorten-64-to-32]
- WARN | xcodebuild: OLMKit/lib/ed25519/src/fe.c:829:12: warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'int32_t' (aka 'int') [-Wshorten-64-to-32]
- WARN | xcodebuild: OLMKit/lib/ed25519/src/fe.c:830:12: warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'int32_t' (aka 'int') [-Wshorten-64-to-32]
- WARN | xcodebuild: OLMKit/lib/ed25519/src/fe.c:831:12: warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'int32_t' (aka 'int') [-Wshorten-64-to-32]
- WARN | xcodebuild: OLMKit/lib/ed25519/src/fe.c:832:12: warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'int32_t' (aka 'int') [-Wshorten-64-to-32]
- WARN | xcodebuild: OLMKit/lib/ed25519/src/fe.c:833:12: warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'int32_t' (aka 'int') [-Wshorten-64-to-32]
- WARN | xcodebuild: OLMKit/lib/ed25519/src/fe.c:834:12: warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'int32_t' (aka 'int') [-Wshorten-64-to-32]
- WARN | [OLMKit/olmc] xcodebuild: OLMKit/lib/curve25519-donna/curve25519-donna.c:480:16: warning: implicit conversion loses integer precision: 'limb' (aka 'long long') to 's32' (aka 'int') [-Wshorten-64-to-32]
- WARN | [OLMKit/olmcpp] xcodebuild: OLMKit/src/base64.cpp:73:47: warning: implicit conversion loses integer precision: 'long' to 'unsigned int' [-Wshorten-64-to-32]
- WARN | [OLMKit/olmcpp] xcodebuild: OLMKit/src/base64.cpp:131:47: warning: implicit conversion loses integer precision: 'long' to 'unsigned int' [-Wshorten-64-to-32]
- WARN | [OLMKit/olmc] xcodebuild: OLMKit/lib/crypto-algorithms/aes.h:117:13: warning: this function declaration is not a prototype [-Wstrict-prototypes]
- WARN | [OLMKit/olmc] xcodebuild: OLMKit/lib/crypto-algorithms/aes.h:118:17: warning: this function declaration is not a prototype [-Wstrict-prototypes]
- WARN | [OLMKit/olmc] xcodebuild: OLMKit/lib/crypto-algorithms/aes.h:119:17: warning: this function declaration is not a prototype [-Wstrict-prototypes]
- WARN | [OLMKit/olmc] xcodebuild: OLMKit/lib/crypto-algorithms/aes.h:120:17: warning: this function declaration is not a prototype [-Wstrict-prototypes]
- WARN | [OLMKit/olmc] xcodebuild: OLMKit/lib/crypto-algorithms/aes.h:121:17: warning: this function declaration is not a prototype [-Wstrict-prototypes]
- WARN | [OLMKit/olmc] xcodebuild: OLMKit/lib/crypto-algorithms/aes.c:243:18: warning: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Wshorten-64-to-32]
- WARN | [OLMKit/olmc] xcodebuild: OLMKit/lib/crypto-algorithms/aes.c:265:18: warning: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Wshorten-64-to-32]
- WARN | xcodebuild: OLMKit/xcode/OLMKit/OLMKit.m:30:55: warning: format specifies type 'unsigned ptrdiff_t' (aka 'unsigned long') but the argument has type 'uint8_t' (aka 'unsigned char') [-Wformat]
- WARN | xcodebuild: OLMKit/xcode/OLMKit/OLMKit.m:30:62: warning: format specifies type 'unsigned ptrdiff_t' (aka 'unsigned long') but the argument has type 'uint8_t' (aka 'unsigned char') [-Wformat]
- WARN | xcodebuild: OLMKit/xcode/OLMKit/OLMKit.m:30:69: warning: format specifies type 'unsigned ptrdiff_t' (aka 'unsigned long') but the argument has type 'uint8_t' (aka 'unsigned char') [-Wformat]
- NOTE | [OLMKit/olmc,OLMKit/olmcpp] xcodebuild: /var/folders/qx/s5rm3bcj71qgpbxqbdgn54140000gn/T/CocoaPods-Lint-20210906-62461-klijc5-OLMKit/App.xcodeproj: warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 6.0, but the range of supported deployment target versions is 9.0 to 14.5.99. (in target 'App' from project 'App')
- NOTE | [OLMKit/olmc,OLMKit/olmcpp] xcodebuild: warning: Skipping code signing because the target does not have an Info.plist file and one is not being generated automatically. (in target 'App' from project 'App')
- NOTE | [OLMKit/olmc,OLMKit/olmcpp] xcodebuild: Pods.xcodeproj: warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 6.0, but the range of supported deployment target versions is 9.0 to 14.5.99. (in target 'Pods-App' from project 'Pods')
- NOTE | [OLMKit/olmc,OLMKit/olmcpp] xcodebuild: note: Using codesigning identity override:
- ERROR | [OLMKit/olmc,OLMKit/olmcpp] xcodebuild: Returned an unsuccessful exit code. You can use `--verbose` for more information.
- ERROR | [OLMKit/olmc] xcodebuild: OLMKit/src/sas.c:29:14: error: conflicting types for 'olm_sas_last_error'
- NOTE | [OLMKit/olmc] xcodebuild: /Users/manu/dev/matrix/git/ios/olm/include/olm/sas.h:38:14: note: previous declaration is here
- ERROR | [OLMKit/olmc] xcodebuild: OLMKit/src/sas.c:53:8: error: conflicting types for 'olm_create_sas_random_length'
- NOTE | [OLMKit/olmc] xcodebuild: /Users/manu/dev/matrix/git/ios/olm/include/olm/sas.h:63:8: note: previous declaration is here
- ERROR | [OLMKit/olmc] xcodebuild: OLMKit/src/sas.c:70:8: error: conflicting types for 'olm_sas_pubkey_length'
- NOTE | [OLMKit/olmc] xcodebuild: /Users/manu/dev/matrix/git/ios/olm/include/olm/sas.h:84:8: note: previous declaration is here
- ERROR | [OLMKit/olmc] xcodebuild: OLMKit/src/sas.c:110:5: error: conflicting types for 'olm_sas_is_their_key_set'
- NOTE | [OLMKit/olmc] xcodebuild: /Users/manu/dev/matrix/git/ios/olm/include/olm/sas.h:121:5: note: previous declaration is here
- ERROR | [OLMKit/olmc] xcodebuild: OLMKit/src/sas.c:134:8: error: conflicting types for 'olm_sas_mac_length'
- NOTE | [OLMKit/olmc] xcodebuild: /Users/manu/dev/matrix/git/ios/olm/include/olm/sas.h:146:8: note: previous declaration is here
- ERROR | [OLMKit/olmcpp] xcodebuild: OLMKit/src/utility.cpp:25:22: error: out-of-line definition of 'sha256_length' does not match any declaration in 'olm::Utility'
- NOTE | [OLMKit/olmcpp] xcodebuild: /Users/manu/dev/matrix/git/ios/olm/include/olm/utility.hh:35:17: note: member declaration does not match because it is const qualified
Analyzed 1 podspec.
[!] The spec did not pass validation, due to 7 errors.https://gitlab.matrix.org/matrix-org/olm/-/issues/5Publish OLM library on a maven reporsitory2022-06-16T15:43:51ZBenoît MartyPublish OLM library on a maven reporsitoryCI of Element Android is regularly broken because Jitpack is not ab le to provide the OLM library.
See for instance https://buildkite.com/matrix-dot-org/element-android/builds/1719
Logs:
```
Could not determine the dependencies of task...CI of Element Android is regularly broken because Jitpack is not ab le to provide the OLM library.
See for instance https://buildkite.com/matrix-dot-org/element-android/builds/1719
Logs:
```
Could not determine the dependencies of task ':vector:lintFdroidRelease'.
> Could not resolve all artifacts for configuration ':vector:gplayDebugRuntimeClasspath'.
> Could not find org.matrix.gitlab.matrix-org:olm:3.2.2.
Searched in the following locations:
- https://jitpack.io/org/matrix/gitlab/matrix-org/olm/3.2.2/olm-3.2.2.pom
- https://oss.sonatype.org/content/repositories/snapshots/org/matrix/gitlab/matrix-org/olm/3.2.2/olm-3.2.2.pom
- https://github.com/vector-im/jitsi_libre_maven/raw/master/android-sdk-3.1.0/org/matrix/gitlab/matrix-org/olm/3.2.2/olm-3.2.2.pom
- https://dl.google.com/dl/android/maven2/org/matrix/gitlab/matrix-org/olm/3.2.2/olm-3.2.2.pom
- https://jcenter.bintray.com/org/matrix/gitlab/matrix-org/olm/3.2.2/olm-3.2.2.pom
Required by:
project :vector > project :matrix-sdk-android
```
It can last a fews days, which is really annoying and can make releases to be postpone.
We should publish the OLM library to an official maven repository, to get ride of the (unidentified so far) issue with Jitpackhttps://gitlab.matrix.org/matrix-org/olm/-/issues/3Symbol not found: _olm_account_fallback_key2021-08-27T14:17:12ZTomSymbol not found: _olm_account_fallback_keyDoes this mean anything to anyone?
```
Unable to import answers_bot.main: dlopen(/Users/tom/.virtualenvs/answers-bot/lib/python3.7/site-packages/python_olm-3.1.5-py3.7-macosx-10.14-x86_64.egg/_libolm.abi3.so, 2): Symbol not found: _olm_...Does this mean anything to anyone?
```
Unable to import answers_bot.main: dlopen(/Users/tom/.virtualenvs/answers-bot/lib/python3.7/site-packages/python_olm-3.1.5-py3.7-macosx-10.14-x86_64.egg/_libolm.abi3.so, 2): Symbol not found: _olm_account_fallback_key
Referenced from: /Users/tom/.virtualenvs/answers-bot/lib/python3.7/site-packages/python_olm-3.1.5-py3.7-macosx-10.14-x86_64.egg/_libolm.abi3.so
Expected in: flat namespace
in /Users/tom/.virtualenvs/answers-bot/lib/python3.7/site-packages/python_olm-3.1.5-py3.7-macosx-10.14-x86_64.egg/_libolm.abi3.so
```