Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
matrix-org
Olm
Commits
570e8bbe
Commit
570e8bbe
authored
Jan 04, 2017
by
ylecollen
Browse files
use secureRandom in getRandomKey
parent
ce9f67d5
Changes
1
Show whitespace changes
Inline
Side-by-side
java/android/OlmLibSdk/olm-sdk/src/main/java/org/matrix/olm/OlmUtility.java
View file @
570e8bbe
...
...
@@ -20,7 +20,7 @@ package org.matrix.olm;
import
android.text.TextUtils
;
import
android.util.Log
;
import
java.
util.
Random
;
import
java.
security.Secure
Random
;
/**
* Olm SDK helper class.
...
...
@@ -138,16 +138,10 @@ public class OlmUtility {
* @return string containing randoms integer values
*/
public
static
String
getRandomKey
()
{
String
keyRetValue
;
Random
rand
=
new
Random
();
StringBuilder
strBuilder
=
new
StringBuilder
();
for
(
int
i
=
0
;
i
<
RANDOM_KEY_SIZE
;
i
++)
{
strBuilder
.
append
(
rand
.
nextInt
(
RANDOM_RANGE
));
}
keyRetValue
=
strBuilder
.
toString
();
return
keyRetValue
;
SecureRandom
secureRandom
=
new
SecureRandom
();
byte
[]
buffer
=
new
byte
[
RANDOM_KEY_SIZE
];
secureRandom
.
nextBytes
(
buffer
);
return
new
String
(
buffer
);
}
/**
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment