Commit c325db02 authored by Denis Kasak's avatar Denis Kasak
Browse files

megolm: Fix use of uninitialized value in group message decoding.

_olm_decode_group_message should initialize all fields of the results
struct before returning. This is because its caller
_decrypt_max_plaintext_length relies on it having initialized these

Luckily, this only allows one to subvert the version check in
_decrypt_max_plaintext_length, but not the following check that the
ciphertext field is non-null because that field *is* initialized.
parent 0a7b6da9
......@@ -373,7 +373,9 @@ void _olm_decode_group_message(
std::uint8_t const * unknown = nullptr;
bool has_message_index = false;
results->version = 0;
results->message_index = 0;
results->has_message_index = (int)has_message_index;
results->ciphertext = nullptr;
results->ciphertext_length = 0;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment