1. 18 Mar, 2021 1 commit
  2. 02 Feb, 2021 1 commit
  3. 31 Jan, 2021 1 commit
    • poljar's avatar
      sas: Fix the base64 encoding of the MAC. · 4e927eb1
      poljar authored
      When calculating the MAC for a message using olm_sas_calculate_mac() and
      olm_sas_calculate_mac_long_kdf() the resulting MAC will be base64
      encoded using _olm_encode_base64().
      
      The _olm_encode_base64() method requires an input buffer and output
      buffer to be passed alongside the input length. The method is called
      with the same buffer, containing the MAC, for the input buffer as well
      as for the output buffer. This results in an incorrectly base64 encoded
      MAC.
      
      For example the byte array:
          [121, 105, 187, 19, 37, 94, 119, 248, 224, 34, 94, 29, 157, 5,
           15, 230, 246, 115, 236, 217, 80, 78, 56, 200, 80, 200, 82, 158,
           168, 179, 10, 230]
      
      will be encoded as  eWm7NyVeVmXgbVhnYlZobllsWm9ibGxzV205aWJHeHo
      instead of as       eWm7EyVed/jgIl4dnQUP5vZz7NlQTjjIUMhSnqizCuY
      
      Notice the different value at the 10th character.
      
      The correct result can be independently checked using Python for
      example:
      
      >>> from base64 import b64encode
      >>> mac = [121, 105, 187, 19, 37, 94, 119, 248, 224, 34, 94, 29, 157, \
                 5, 15, 230, 246, 115, 236, 217, 80, 78, 56, 200, 80, 200, \
                 82, 158, 168, 179, 10, 230]
      >>> b64encode(bytearray(mac)).rstrip(b"=")
      >>> b'eWm7EyVed/jgIl4dnQUP5vZz7NlQTjjIUMhSnqizCuY'
      
      This happens because the encode_base64() method that is used does not support
      in-place encoding in the general case. This is because the remainder for a 32
      bit input will always be 2 (32 % 6 == 2).
      
      The remainder will be used over here:
      https://gitlab.matrix.org/matrix-org/olm/-/blob/c01164f001d57fbe2297fe11954b58077a68dc0d/src/base64.cpp#L74
      
      The logic that gets executed if a remainder exists depends on the original input
      values, since those already got in-place encoded the whole block will behave
      differently if the input buffer is the same as the output buffer.
      4e927eb1
  4. 24 Nov, 2020 1 commit
  5. 23 Sep, 2020 3 commits
  6. 16 Sep, 2020 1 commit
  7. 14 Aug, 2020 1 commit
  8. 08 Oct, 2019 1 commit
  9. 04 Oct, 2019 1 commit
  10. 01 Oct, 2019 1 commit
    • David Baker's avatar
      Add olm_session_describe · 39a1ee0b
      David Baker authored
      As a way to dump the state of an olm session, ie. the chain indicies,
      so we can debug why olm sessions break and get out of sync.
      39a1ee0b
  11. 15 May, 2019 1 commit
  12. 14 May, 2019 1 commit
  13. 03 Apr, 2019 1 commit
  14. 14 Mar, 2019 1 commit
  15. 01 Feb, 2019 1 commit
  16. 29 Jan, 2019 1 commit
  17. 22 Jan, 2019 1 commit
  18. 15 Oct, 2018 1 commit
  19. 11 Oct, 2018 1 commit
  20. 05 Oct, 2018 1 commit
  21. 02 Oct, 2018 1 commit
    • David Baker's avatar
      Work with PkDecryption keys by their private keys · 0346145a
      David Baker authored
      Change interface to allow the app to get the private part of the
      key and instantiate a decryption object from just the private part
      of the key.
      
      Changes the function generating a key from random bytes to be
      initialising a key with a private key (because it's exactly the
      same thing). Exports & imports private key parts as ArrayBuffer at
      JS level rather than base64 assuming we are moving that way in
      general.
      0346145a
  22. 19 Sep, 2018 1 commit
  23. 28 Jun, 2018 2 commits
  24. 27 Jun, 2018 3 commits
  25. 29 Sep, 2017 2 commits
  26. 10 Jan, 2017 2 commits
  27. 09 Jan, 2017 1 commit
  28. 06 Jan, 2017 1 commit
  29. 24 Oct, 2016 1 commit
    • Richard van der Hoff's avatar
      Return the base64-encoded length of pickles · a7310c58
      Richard van der Hoff authored
      make olm_pickle_* return the lengths of the base64-encoded pickles, rather than
      the raw pickle. (From the application's POV, the format of the pickle is
      opaque: it doesn't even know that it is base64-encoded. So returning the length
      of the raw pickle is particularly unhelpful.)
      a7310c58
  30. 21 Oct, 2016 1 commit
  31. 20 Oct, 2016 2 commits
  32. 19 Oct, 2016 1 commit