Skip to content

Lint fails for the iOS lib

Running the cocoapods linter currently fails on develop. This prevents us from making a release.

❯ pod spec lint OLMKit.podspec --use-libraries --allow-warnings

/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:4: warning: already initialized constant Pod::MAJOR
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:4: warning: previous definition of MAJOR was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:5: warning: already initialized constant Pod::MINOR
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:5: warning: previous definition of MINOR was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:6: warning: already initialized constant Pod::PATCH
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:6: warning: previous definition of PATCH was here
/var/folders/qx/s5rm3bcj71qgpbxqbdgn54140000gn/T/d20210906-62461-10osbq8/OLMKit.podspec:4: warning: already initialized constant Pod::MAJOR
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:4: warning: previous definition of MAJOR was here
/var/folders/qx/s5rm3bcj71qgpbxqbdgn54140000gn/T/d20210906-62461-10osbq8/OLMKit.podspec:5: warning: already initialized constant Pod::MINOR
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:5: warning: previous definition of MINOR was here
/var/folders/qx/s5rm3bcj71qgpbxqbdgn54140000gn/T/d20210906-62461-10osbq8/OLMKit.podspec:6: warning: already initialized constant Pod::PATCH
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:6: warning: previous definition of PATCH was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:4: warning: already initialized constant Pod::MAJOR
/var/folders/qx/s5rm3bcj71qgpbxqbdgn54140000gn/T/d20210906-62461-10osbq8/OLMKit.podspec:4: warning: previous definition of MAJOR was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:5: warning: already initialized constant Pod::MINOR
/var/folders/qx/s5rm3bcj71qgpbxqbdgn54140000gn/T/d20210906-62461-10osbq8/OLMKit.podspec:5: warning: previous definition of MINOR was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:6: warning: already initialized constant Pod::PATCH
/var/folders/qx/s5rm3bcj71qgpbxqbdgn54140000gn/T/d20210906-62461-10osbq8/OLMKit.podspec:6: warning: previous definition of PATCH was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:4: warning: already initialized constant Pod::MAJOR
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:4: warning: previous definition of MAJOR was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:5: warning: already initialized constant Pod::MINOR
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:5: warning: previous definition of MINOR was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:6: warning: already initialized constant Pod::PATCH
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:6: warning: previous definition of PATCH was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:4: warning: already initialized constant Pod::MAJOR
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:4: warning: previous definition of MAJOR was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:5: warning: already initialized constant Pod::MINOR
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:5: warning: previous definition of MINOR was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:6: warning: already initialized constant Pod::PATCH
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:6: warning: previous definition of PATCH was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:4: warning: already initialized constant Pod::MAJOR
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:4: warning: previous definition of MAJOR was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:5: warning: already initialized constant Pod::MINOR
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:5: warning: previous definition of MINOR was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:6: warning: already initialized constant Pod::PATCH
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:6: warning: previous definition of PATCH was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:4: warning: already initialized constant Pod::MAJOR
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:4: warning: previous definition of MAJOR was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:5: warning: already initialized constant Pod::MINOR
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:5: warning: previous definition of MINOR was here
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:6: warning: already initialized constant Pod::PATCH
/Users/manu/dev/matrix/git/ios/olm/OLMKit.podspec:6: warning: previous definition of PATCH was here
 -> OLMKit (3.2.4)
    - NOTE  | [OLMKit/olmc,OLMKit/olmcpp] xcodebuild:  note: Using new build system
    - NOTE  | [OLMKit/olmc,OLMKit/olmcpp] xcodebuild:  note: Building targets in parallel
    - NOTE  | [OLMKit/olmc,OLMKit/olmcpp] xcodebuild:  note: Using codesigning identity override: -
    - NOTE  | [OLMKit/olmc,OLMKit/olmcpp] xcodebuild:  note: Build preparation complete
    - NOTE  | [OLMKit/olmc,OLMKit/olmcpp] xcodebuild:  note: Planning build
    - NOTE  | [OLMKit/olmc,OLMKit/olmcpp] xcodebuild:  note: Analyzing workspace
    - NOTE  | [OLMKit/olmc,OLMKit/olmcpp] xcodebuild:  note: Constructing build description
    - NOTE  | [OLMKit/olmc,OLMKit/olmcpp] xcodebuild:  Pods.xcodeproj: warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 6.0, but the range of supported deployment target versions is 9.0 to 14.5.99. (in target 'OLMKit' from project 'Pods')
    - WARN  | xcodebuild:  OLMKit/src/ratchet.cpp:38:11: warning: parameter 'new_root_key[out]' not found in the function declaration [-Wdocumentation]
    - NOTE  | xcodebuild:  OLMKit/src/ratchet.cpp:38:11: note: did you mean 'new_root_key'?
    - WARN  | xcodebuild:  OLMKit/src/ratchet.cpp:39:11: warning: parameter 'new_chain_key[out]' not found in the function declaration [-Wdocumentation]
    - NOTE  | xcodebuild:  OLMKit/src/ratchet.cpp:39:11: note: did you mean 'new_chain_key'?
    - WARN  | xcodebuild:  OLMKit/src/ratchet.cpp:412:9: warning: implicit conversion loses integer precision: 'std::size_t' (aka 'unsigned long') to 'std::uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32]
    - WARN  | xcodebuild:  OLMKit/lib/ed25519/src/fe.c:825:12: warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'int32_t' (aka 'int') [-Wshorten-64-to-32]
    - WARN  | xcodebuild:  OLMKit/lib/ed25519/src/fe.c:826:12: warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'int32_t' (aka 'int') [-Wshorten-64-to-32]
    - WARN  | xcodebuild:  OLMKit/lib/ed25519/src/fe.c:827:12: warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'int32_t' (aka 'int') [-Wshorten-64-to-32]
    - WARN  | xcodebuild:  OLMKit/lib/ed25519/src/fe.c:828:12: warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'int32_t' (aka 'int') [-Wshorten-64-to-32]
    - WARN  | xcodebuild:  OLMKit/lib/ed25519/src/fe.c:829:12: warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'int32_t' (aka 'int') [-Wshorten-64-to-32]
    - WARN  | xcodebuild:  OLMKit/lib/ed25519/src/fe.c:830:12: warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'int32_t' (aka 'int') [-Wshorten-64-to-32]
    - WARN  | xcodebuild:  OLMKit/lib/ed25519/src/fe.c:831:12: warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'int32_t' (aka 'int') [-Wshorten-64-to-32]
    - WARN  | xcodebuild:  OLMKit/lib/ed25519/src/fe.c:832:12: warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'int32_t' (aka 'int') [-Wshorten-64-to-32]
    - WARN  | xcodebuild:  OLMKit/lib/ed25519/src/fe.c:833:12: warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'int32_t' (aka 'int') [-Wshorten-64-to-32]
    - WARN  | xcodebuild:  OLMKit/lib/ed25519/src/fe.c:834:12: warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'int32_t' (aka 'int') [-Wshorten-64-to-32]
    - WARN  | [OLMKit/olmc] xcodebuild:  OLMKit/lib/curve25519-donna/curve25519-donna.c:480:16: warning: implicit conversion loses integer precision: 'limb' (aka 'long long') to 's32' (aka 'int') [-Wshorten-64-to-32]
    - WARN  | [OLMKit/olmcpp] xcodebuild:  OLMKit/src/base64.cpp:73:47: warning: implicit conversion loses integer precision: 'long' to 'unsigned int' [-Wshorten-64-to-32]
    - WARN  | [OLMKit/olmcpp] xcodebuild:  OLMKit/src/base64.cpp:131:47: warning: implicit conversion loses integer precision: 'long' to 'unsigned int' [-Wshorten-64-to-32]
    - WARN  | [OLMKit/olmc] xcodebuild:  OLMKit/lib/crypto-algorithms/aes.h:117:13: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [OLMKit/olmc] xcodebuild:  OLMKit/lib/crypto-algorithms/aes.h:118:17: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [OLMKit/olmc] xcodebuild:  OLMKit/lib/crypto-algorithms/aes.h:119:17: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [OLMKit/olmc] xcodebuild:  OLMKit/lib/crypto-algorithms/aes.h:120:17: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [OLMKit/olmc] xcodebuild:  OLMKit/lib/crypto-algorithms/aes.h:121:17: warning: this function declaration is not a prototype [-Wstrict-prototypes]
    - WARN  | [OLMKit/olmc] xcodebuild:  OLMKit/lib/crypto-algorithms/aes.c:243:18: warning: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Wshorten-64-to-32]
    - WARN  | [OLMKit/olmc] xcodebuild:  OLMKit/lib/crypto-algorithms/aes.c:265:18: warning: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Wshorten-64-to-32]
    - WARN  | xcodebuild:  OLMKit/xcode/OLMKit/OLMKit.m:30:55: warning: format specifies type 'unsigned ptrdiff_t' (aka 'unsigned long') but the argument has type 'uint8_t' (aka 'unsigned char') [-Wformat]
    - WARN  | xcodebuild:  OLMKit/xcode/OLMKit/OLMKit.m:30:62: warning: format specifies type 'unsigned ptrdiff_t' (aka 'unsigned long') but the argument has type 'uint8_t' (aka 'unsigned char') [-Wformat]
    - WARN  | xcodebuild:  OLMKit/xcode/OLMKit/OLMKit.m:30:69: warning: format specifies type 'unsigned ptrdiff_t' (aka 'unsigned long') but the argument has type 'uint8_t' (aka 'unsigned char') [-Wformat]
    - NOTE  | [OLMKit/olmc,OLMKit/olmcpp] xcodebuild:  /var/folders/qx/s5rm3bcj71qgpbxqbdgn54140000gn/T/CocoaPods-Lint-20210906-62461-klijc5-OLMKit/App.xcodeproj: warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 6.0, but the range of supported deployment target versions is 9.0 to 14.5.99. (in target 'App' from project 'App')
    - NOTE  | [OLMKit/olmc,OLMKit/olmcpp] xcodebuild:  warning: Skipping code signing because the target does not have an Info.plist file and one is not being generated automatically. (in target 'App' from project 'App')
    - NOTE  | [OLMKit/olmc,OLMKit/olmcpp] xcodebuild:  Pods.xcodeproj: warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 6.0, but the range of supported deployment target versions is 9.0 to 14.5.99. (in target 'Pods-App' from project 'Pods')
    - NOTE  | [OLMKit/olmc,OLMKit/olmcpp] xcodebuild:  note: Using codesigning identity override: 
    - ERROR | [OLMKit/olmc,OLMKit/olmcpp] xcodebuild: Returned an unsuccessful exit code. You can use `--verbose` for more information.
    - ERROR | [OLMKit/olmc] xcodebuild:  OLMKit/src/sas.c:29:14: error: conflicting types for 'olm_sas_last_error'
    - NOTE  | [OLMKit/olmc] xcodebuild:  /Users/manu/dev/matrix/git/ios/olm/include/olm/sas.h:38:14: note: previous declaration is here
    - ERROR | [OLMKit/olmc] xcodebuild:  OLMKit/src/sas.c:53:8: error: conflicting types for 'olm_create_sas_random_length'
    - NOTE  | [OLMKit/olmc] xcodebuild:  /Users/manu/dev/matrix/git/ios/olm/include/olm/sas.h:63:8: note: previous declaration is here
    - ERROR | [OLMKit/olmc] xcodebuild:  OLMKit/src/sas.c:70:8: error: conflicting types for 'olm_sas_pubkey_length'
    - NOTE  | [OLMKit/olmc] xcodebuild:  /Users/manu/dev/matrix/git/ios/olm/include/olm/sas.h:84:8: note: previous declaration is here
    - ERROR | [OLMKit/olmc] xcodebuild:  OLMKit/src/sas.c:110:5: error: conflicting types for 'olm_sas_is_their_key_set'
    - NOTE  | [OLMKit/olmc] xcodebuild:  /Users/manu/dev/matrix/git/ios/olm/include/olm/sas.h:121:5: note: previous declaration is here
    - ERROR | [OLMKit/olmc] xcodebuild:  OLMKit/src/sas.c:134:8: error: conflicting types for 'olm_sas_mac_length'
    - NOTE  | [OLMKit/olmc] xcodebuild:  /Users/manu/dev/matrix/git/ios/olm/include/olm/sas.h:146:8: note: previous declaration is here
    - ERROR | [OLMKit/olmcpp] xcodebuild:  OLMKit/src/utility.cpp:25:22: error: out-of-line definition of 'sha256_length' does not match any declaration in 'olm::Utility'
    - NOTE  | [OLMKit/olmcpp] xcodebuild:  /Users/manu/dev/matrix/git/ios/olm/include/olm/utility.hh:35:17: note: member declaration does not match because it is const qualified

Analyzed 1 podspec.

[!] The spec did not pass validation, due to 7 errors.
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information